Skip to content

Commit 0ad0f94

Browse files
committed
More PR feedback
1 parent 3b30202 commit 0ad0f94

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

main.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -681,11 +681,7 @@ static int main_inner(int argc, char *argv[])
681681
cbs.add("--flip-vert-y", [&args](CLIParser &) { args.yflip = true; });
682682
cbs.add("--iterations", [&args](CLIParser &parser) { args.iterations = parser.next_uint(); });
683683
cbs.add("--cpp", [&args](CLIParser &) { args.cpp = true; });
684-
cbs.add("--reflect", [&args](CLIParser &parser) {
685-
// force vulkan semantics for reflection
686-
args.vulkan_semantics = true;
687-
args.reflect = parser.next_value_string("json");
688-
});
684+
cbs.add("--reflect", [&args](CLIParser &parser) { args.reflect = parser.next_value_string("json"); });
689685
cbs.add("--cpp-interface-name", [&args](CLIParser &parser) { args.cpp_interface_name = parser.next_string(); });
690686
cbs.add("--metal", [&args](CLIParser &) { args.msl = true; }); // Legacy compatibility
691687
cbs.add("--msl", [&args](CLIParser &) { args.msl = true; });

update_test_shaders.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,6 @@ echo "Using spirv-opt in: $(which spirv-opt)."
1616
./test_shaders.py shaders-hlsl --update --hlsl || exit 1
1717
./test_shaders.py shaders-hlsl --update --hlsl --opt || exit 1
1818
./test_shaders.py shaders-hlsl-no-opt --update --hlsl || exit 1
19+
./test_shaders.py shaders-reflection --reflect --update || exit 1
1920

2021

0 commit comments

Comments
 (0)