Websocket handling has changed

[esticle]

Having recently upgraded from Swag 1.7.0 to 1.8.0 and re-rolling from the sample configs. I noticed that the removal of two lines in this commit has broken the websocket connection under 'Alerts' for a server.

A copied Plex sample config has had these two lines removed between v1.7.0 and 1.8.0:

proxy_set_header        Upgrade         $http_upgrade;
proxy_set_header        Connection      "upgrade";

If you are accessing your Plex instance via Swag/a configuration using these reverse-proxy-confs at version 1.8.0 you will notice that going to Settings -> Alerts you will get the text: Unable to listen for events on servername.

This is fixed by re-adding the above two lines.

Thanks.

[Roxedus]

How outdated is your nginx.conf and proxy.conf?

[esticle]

How outdated is your nginx.conf and proxy.conf?

Thanks for the hint - my nginx.conf was from Swag 1.7.0 which (of course) had this commit when it moved to 1.8.0 to sync with the reverse-proxy-confs removal of the same - which explains it all.

Know what to look for next time around now, thanks for the help!

[nemchik]

Ref: #201 #200 #199

[nemchik]

For future users:

I've edited the subject, and in pinned this issue so it will be visible even while closed, and I'm locking discussion after posting this.

Proxy configs with web sockets are now handled differently. Users need to manually update their proxy.conf and nginx.conf. See the SWAG readme for more info. https://github.com/linuxserver/docker-swag#updating-configs

We do not need PRs to add back the web socket lines that were removed.

Thanks.