Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Image preview stops to work after image upload #244

Open
1 task done
gldhnchn opened this issue Dec 11, 2024 · 6 comments
Open
1 task done

[BUG] Image preview stops to work after image upload #244

gldhnchn opened this issue Dec 11, 2024 · 6 comments
Assignees
Labels
bug Something isn't working upstream issue

Comments

@gldhnchn
Copy link

gldhnchn commented Dec 11, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

I updated my docker bookstack instance from

"build_version": "Linuxserver.io version:- v24.05.2-ls151 Build-date:- 2024-06-17T18:25:38+00:00",
"org.opencontainers.image.ref.name": "82e27df9721a1f94fb4400d4a53634547fafd13c",

to

"build_version": "Linuxserver.io version:- v24.10.3-ls179 Build-date:- 2024-12-02T18:35:15+00:00",
"org.opencontainers.image.ref.name": "b52e28a1a2bc0c5f5e586c21043b1eb130518e12",

with the command

docker-compose pull  && docker-compose up -d

I did this to solve the issue EXIF data is ignored when uploading images, which should have been fixed by the commit Add php83-exif for reading image EXIF data. After the upgrade it got now worse. When I upload a new .jpg Picture the image preview breaks. It doesn't break after uploading a new .png image. The image preview will stay in this state:
grafik
I can press Load More which will trigger some images to load, but I think some are still missing. I guess it depends on the images having specific EXIF meta data or not.

Edit: I can confirm this as when I take a image that is breaking the preview, open it in paint, save it as a new .jpg, the image doesn't break the preview anymore.

I can fix the issue temporarily by going into the running docker container and run php artisan -f bookstack:cleanup-images. But when I try to reupload the image, it will break again.

Expected Behavior

No response

Steps To Reproduce

  1. Upload a new image
  2. Click on insert image

Environment

- OS: Debian 12
- Hardware: Raspberry Pi 5

CPU architecture

arm64

Docker creation

docker-compose.yml:
---
version: "2"
services:
  bookstack:
    image: lscr.io/linuxserver/bookstack
    container_name: bookstack
    environment:
      - PUID=2001
      - PGID=2001
      - APP_URL=http://192.168.178.185
      - DB_HOST=bookstack_db
      - DB_PORT=3306
      - DB_USER=bookstack
      - DB_PASS=mypassword
      - DB_DATABASE=bookstackapp
    volumes:
      - ./bookstack_app_data:/config
    ports:
      - 127.0.0.1:6875:80
    restart: unless-stopped
    depends_on:
      - bookstack_db
  bookstack_db:
    image: lscr.io/linuxserver/mariadb
    container_name: bookstack_db
    environment:
      - PUID=1000
      - PGID=1000
      - MYSQL_ROOT_PASSWORD=mypassword
      - TZ=Europe/Berlin
      - MYSQL_DATABASE=bookstackapp
      - MYSQL_USER=bookstack
      - MYSQL_PASSWORD=mypassword
    volumes:
      - ./bookstack_db_data:/config
    restart: unless-stopped

Container logs

[migrations] started
[migrations] 01-nginx-site-confs-default: skipped
[migrations] 02-default-location: skipped
[migrations] done
───────────────────────────────────────

      ██╗     ███████╗██╗ ██████╗
      ██║     ██╔════╝██║██╔═══██╗
      ██║     ███████╗██║██║   ██║
      ██║     ╚════██║██║██║   ██║
      ███████╗███████║██║╚██████╔╝
      ╚══════╝╚══════╝╚═╝ ╚═════╝

   Brought to you by linuxserver.io
───────────────────────────────────────

To support LSIO projects visit:
https://www.linuxserver.io/donate/

───────────────────────────────────────
GID/UID
───────────────────────────────────────

User UID:    2001
User GID:    2001
───────────────────────────────────────
Linuxserver.io version: v24.10.3-ls179
Build-date: 2024-12-02T18:35:15+00:00
───────────────────────────────────────

using keys found in /config/keys
Waiting for DB to be available

   INFO  Running migrations.

  2024_09_29_140340_ensure_editor_value_set ........................ 31ms DONE

**** The following active confs have different version dates than the samples that are shipped. ****
**** This may be due to user customization or an update to the samples. ****
**** You should compare the following files to the samples in the same folder and update them. ****
**** Use the link at the top of the file to view the changelog. ****
┌────────────┬────────────┬────────────────────────────────────────────────────────────────────────┐
│  old date  │  new date  │ path                                                                   │
├────────────┼────────────┼────────────────────────────────────────────────────────────────────────┤
│ 2024-05-27 │ 2024-07-16 │ /config/nginx/site-confs/default.conf                                  │
└────────────┴────────────┴────────────────────────────────────────────────────────────────────────┘
[custom-init] No custom files found, skipping...
[ls.io-init] done.
[migrations] started
[migrations] 01-nginx-site-confs-default: skipped
[migrations] 02-default-location: skipped
[migrations] done
usermod: no changes
───────────────────────────────────────

      ██╗     ███████╗██╗ ██████╗
      ██║     ██╔════╝██║██╔═══██╗
      ██║     ███████╗██║██║   ██║
      ██║     ╚════██║██║██║   ██║
      ███████╗███████║██║╚██████╔╝
      ╚══════╝╚══════╝╚═╝ ╚═════╝

   Brought to you by linuxserver.io
───────────────────────────────────────

To support LSIO projects visit:
https://www.linuxserver.io/donate/

───────────────────────────────────────
GID/UID
───────────────────────────────────────

User UID:    2001
User GID:    2001
───────────────────────────────────────
Linuxserver.io version: v24.10.3-ls179
Build-date: 2024-12-02T18:35:15+00:00
───────────────────────────────────────

using keys found in /config/keys
Waiting for DB to be available

   INFO  Nothing to migrate.

**** The following active confs have different version dates than the samples that are shipped. ****
**** This may be due to user customization or an update to the samples. ****
**** You should compare the following files to the samples in the same folder and update them. ****
**** Use the link at the top of the file to view the changelog. ****
┌────────────┬────────────┬────────────────────────────────────────────────────────────────────────┐
│  old date  │  new date  │ path                                                                   │
├────────────┼────────────┼────────────────────────────────────────────────────────────────────────┤
│ 2024-05-27 │ 2024-07-16 │ /config/nginx/site-confs/default.conf                                  │
└────────────┴────────────┴────────────────────────────────────────────────────────────────────────┘
[custom-init] No custom files found, skipping...
[ls.io-init] done.
[migrations] started
[migrations] 01-nginx-site-confs-default: skipped
[migrations] 02-default-location: skipped
[migrations] done
usermod: no changes
───────────────────────────────────────

      ██╗     ███████╗██╗ ██████╗
      ██║     ██╔════╝██║██╔═══██╗
      ██║     ███████╗██║██║   ██║
      ██║     ╚════██║██║██║   ██║
      ███████╗███████║██║╚██████╔╝
      ╚══════╝╚══════╝╚═╝ ╚═════╝

   Brought to you by linuxserver.io
───────────────────────────────────────

To support LSIO projects visit:
https://www.linuxserver.io/donate/

───────────────────────────────────────
GID/UID
───────────────────────────────────────

User UID:    2001
User GID:    2001
───────────────────────────────────────
Linuxserver.io version: v24.10.3-ls179
Build-date: 2024-12-02T18:35:15+00:00
───────────────────────────────────────

using keys found in /config/keys
Waiting for DB to be available

   INFO  Nothing to migrate.

**** The following active confs have different version dates than the samples that are shipped. ****
**** This may be due to user customization or an update to the samples. ****
**** You should compare the following files to the samples in the same folder and update them. ****
**** Use the link at the top of the file to view the changelog. ****
┌────────────┬────────────┬────────────────────────────────────────────────────────────────────────┐
│  old date  │  new date  │ path                                                                   │
├────────────┼────────────┼────────────────────────────────────────────────────────────────────────┤
│ 2024-05-27 │ 2024-07-16 │ /config/nginx/site-confs/default.conf                                  │
└────────────┴────────────┴────────────────────────────────────────────────────────────────────────┘
[custom-init] No custom files found, skipping...
[ls.io-init] done.
[migrations] started
[migrations] 01-nginx-site-confs-default: skipped
[migrations] 02-default-location: skipped
[migrations] done
usermod: no changes
───────────────────────────────────────

      ██╗     ███████╗██╗ ██████╗
      ██║     ██╔════╝██║██╔═══██╗
      ██║     ███████╗██║██║   ██║
      ██║     ╚════██║██║██║   ██║
      ███████╗███████║██║╚██████╔╝
      ╚══════╝╚══════╝╚═╝ ╚═════╝

   Brought to you by linuxserver.io
───────────────────────────────────────

To support LSIO projects visit:
https://www.linuxserver.io/donate/

───────────────────────────────────────
GID/UID
───────────────────────────────────────

User UID:    2001
User GID:    2001
───────────────────────────────────────
Linuxserver.io version: v24.10.3-ls179
Build-date: 2024-12-02T18:35:15+00:00
───────────────────────────────────────

using keys found in /config/keys
Waiting for DB to be available

   INFO  Nothing to migrate.

**** The following active confs have different version dates than the samples that are shipped. ****
**** This may be due to user customization or an update to the samples. ****
**** You should compare the following files to the samples in the same folder and update them. ****
**** Use the link at the top of the file to view the changelog. ****
┌────────────┬────────────┬────────────────────────────────────────────────────────────────────────┐
│  old date  │  new date  │ path                                                                   │
├────────────┼────────────┼────────────────────────────────────────────────────────────────────────┤
│ 2024-05-27 │ 2024-07-16 │ /config/nginx/site-confs/default.conf                                  │
└────────────┴────────────┴────────────────────────────────────────────────────────────────────────┘
[custom-init] No custom files found, skipping...
[ls.io-init] done.
[migrations] started
[migrations] 01-nginx-site-confs-default: skipped
[migrations] 02-default-location: skipped
[migrations] done
usermod: no changes
───────────────────────────────────────

      ██╗     ███████╗██╗ ██████╗
      ██║     ██╔════╝██║██╔═══██╗
      ██║     ███████╗██║██║   ██║
      ██║     ╚════██║██║██║   ██║
      ███████╗███████║██║╚██████╔╝
      ╚══════╝╚══════╝╚═╝ ╚═════╝

   Brought to you by linuxserver.io
───────────────────────────────────────

To support LSIO projects visit:
https://www.linuxserver.io/donate/

───────────────────────────────────────
GID/UID
───────────────────────────────────────

User UID:    2001
User GID:    2001
───────────────────────────────────────
Linuxserver.io version: v24.10.3-ls179
Build-date: 2024-12-02T18:35:15+00:00
───────────────────────────────────────

using keys found in /config/keys
Waiting for DB to be available

   INFO  Nothing to migrate.

**** The following active confs have different version dates than the samples that are shipped. ****
**** This may be due to user customization or an update to the samples. ****
**** You should compare the following files to the samples in the same folder and update them. ****
**** Use the link at the top of the file to view the changelog. ****
┌────────────┬────────────┬────────────────────────────────────────────────────────────────────────┐
│  old date  │  new date  │ path                                                                   │
├────────────┼────────────┼────────────────────────────────────────────────────────────────────────┤
│ 2024-05-27 │ 2024-07-16 │ /config/nginx/site-confs/default.conf                                  │
└────────────┴────────────┴────────────────────────────────────────────────────────────────────────┘
[custom-init] No custom files found, skipping...
[ls.io-init] done.
[migrations] started
[migrations] 01-nginx-site-confs-default: skipped
[migrations] 02-default-location: skipped
[migrations] done
usermod: no changes
───────────────────────────────────────

      ██╗     ███████╗██╗ ██████╗
      ██║     ██╔════╝██║██╔═══██╗
      ██║     ███████╗██║██║   ██║
      ██║     ╚════██║██║██║   ██║
      ███████╗███████║██║╚██████╔╝
      ╚══════╝╚══════╝╚═╝ ╚═════╝

   Brought to you by linuxserver.io
───────────────────────────────────────

To support LSIO projects visit:
https://www.linuxserver.io/donate/

───────────────────────────────────────
GID/UID
───────────────────────────────────────

User UID:    2001
User GID:    2001
───────────────────────────────────────
Linuxserver.io version: v24.10.3-ls179
Build-date: 2024-12-02T18:35:15+00:00
───────────────────────────────────────

using keys found in /config/keys
Waiting for DB to be available

   INFO  Nothing to migrate.

**** The following active confs have different version dates than the samples that are shipped. ****
**** This may be due to user customization or an update to the samples. ****
**** You should compare the following files to the samples in the same folder and update them. ****
**** Use the link at the top of the file to view the changelog. ****
┌────────────┬────────────┬────────────────────────────────────────────────────────────────────────┐
│  old date  │  new date  │ path                                                                   │
├────────────┼────────────┼────────────────────────────────────────────────────────────────────────┤
│ 2024-05-27 │ 2024-07-16 │ /config/nginx/site-confs/default.conf                                  │
└────────────┴────────────┴────────────────────────────────────────────────────────────────────────┘
[custom-init] No custom files found, skipping...
[ls.io-init] done.
[migrations] started
[migrations] 01-nginx-site-confs-default: skipped
[migrations] 02-default-location: skipped
[migrations] done
usermod: no changes
───────────────────────────────────────

      ██╗     ███████╗██╗ ██████╗
      ██║     ██╔════╝██║██╔═══██╗
      ██║     ███████╗██║██║   ██║
      ██║     ╚════██║██║██║   ██║
      ███████╗███████║██║╚██████╔╝
      ╚══════╝╚══════╝╚═╝ ╚═════╝

   Brought to you by linuxserver.io
───────────────────────────────────────

To support LSIO projects visit:
https://www.linuxserver.io/donate/

───────────────────────────────────────
GID/UID
───────────────────────────────────────

User UID:    2001
User GID:    2001
───────────────────────────────────────
Linuxserver.io version: v24.10.3-ls179
Build-date: 2024-12-02T18:35:15+00:00
───────────────────────────────────────

using keys found in /config/keys
Waiting for DB to be available

   INFO  Nothing to migrate.

**** The following active confs have different version dates than the samples that are shipped. ****
**** This may be due to user customization or an update to the samples. ****
**** You should compare the following files to the samples in the same folder and update them. ****
**** Use the link at the top of the file to view the changelog. ****
┌────────────┬────────────┬────────────────────────────────────────────────────────────────────────┐
│  old date  │  new date  │ path                                                                   │
├────────────┼────────────┼────────────────────────────────────────────────────────────────────────┤
│ 2024-05-27 │ 2024-07-16 │ /config/nginx/site-confs/default.conf                                  │
└────────────┴────────────┴────────────────────────────────────────────────────────────────────────┘
[custom-init] No custom files found, skipping...
[ls.io-init] done.
Copy link

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

@thespad
Copy link
Member

thespad commented Dec 11, 2024

I've just done a quick test with my install

Linuxserver.io version: v24.10.3-ls180
Build-date: 2024-12-09T18:31:30+00:00

Uploaded some jpgs but can't replicate the issue. Can you check the laravel log in /config/log and see if that's reporting any errors or other issues?

@ssddanbrown
Copy link
Contributor

This is often due to a lack of memory for thumbnail generation, and I doubt an issue for the linuxserver team.
Effectively the same as existing BookStack issue BookStackApp/BookStack#5108

@gldhnchn
Copy link
Author

gldhnchn commented Dec 11, 2024

Can you check the laravel log in /config/log

In my bookstack_app_data/log/bookstack/laravel.log are no entries from today, so probably nothing related, right?

Uploaded some jpgs

It really depends on the jpgs. Here I got two jpgs. The first one is not breaking the preview, the second one does. (I hope Githubs upload preserves the metadata)

works.jpg

breaks.jpg

@gldhnchn
Copy link
Author

Yes, I can confirm after downloading these images from Github, the behaviour is still the same. I also noticed, that in the uploader there is no Image uploaded successfully message, when the preview breaks.

Screenshot 2024-12-11 153157

@thespad
Copy link
Member

thespad commented Dec 11, 2024

OK, I can replicate it with your images. I would suggest reporting it upstream as I don't think it's anything we're doing wrong, but obviously I'm happy to make any changes we need to to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream issue
Projects
Status: Issues
Development

No branches or pull requests

3 participants