ci: skip most CI checks if title contains citest skip [citest_skip]#4
Merged
ci: skip most CI checks if title contains citest skip [citest_skip]#4
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a mechanism to skip most CI jobs when a pull request title contains the marker "[citest_skip]", adjusts a tft test plan filter, and changes the weekly CI trigger time. Flow diagram for CI job execution decision based on PR title markergraph TD
A["GitHub receives pull_request event"] --> B["Read github.event.pull_request.title"]
B --> C{"Title contains<br>[citest_skip]?"}
C -- Yes --> D["Condition !contains(title,[citest_skip]) is false"]
D --> E["Skip conditional CI jobs<br>(ansible_lint, ansible_managed_var_comment, codespell, markdownlint, woke)"]
C -- No --> F["Condition !contains(title,[citest_skip]) is true"]
F --> G["Run all CI jobs<br>including ansible_lint, ansible_managed_var_comment, codespell, markdownlint, woke"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Using
github.event.pull_request.titlein job-levelifconditions will fail for any workflow that can be triggered by non-pull_requestevents; consider guarding the access (e.g.if: github.event_name == 'pull_request' && !contains(github.event.pull_request.title, '[citest_skip]')) or otherwise ensuring those workflows only ever run onpull_request.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Using `github.event.pull_request.title` in job-level `if` conditions will fail for any workflow that can be triggered by non-`pull_request` events; consider guarding the access (e.g. `if: github.event_name == 'pull_request' && !contains(github.event.pull_request.title, '[citest_skip]')`) or otherwise ensuring those workflows only ever run on `pull_request`.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
When we submit a PR for a CI update or docs, we do not want to start CI checking for ansible-lint, qemu, etc. When we are doing CI updates to 30 or more roles, this fires off a lot of unnecessary tests, which sometimes causes the linux-system-roles org in github to be throttled. When submitting a PR that can skip ci, use "[citest_skip]" in the PR title. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
When we submit a PR for a CI update or docs, we do not want to start CI checking for ansible-lint, qemu, etc. When we are doing CI updates to 30 or more roles, this fires off a lot of unnecessary tests, which sometimes causes the linux-system-roles org in github to be throttled. When submitting a PR that can skip ci, use "[citest_skip]" in the PR title. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we submit a PR for a CI update or docs, we do not want to start CI checking
for ansible-lint, qemu, etc. When we are doing CI updates to 30 or more
roles, this fires off a lot of unnecessary tests, which sometimes causes the
linux-system-roles org in github to be throttled.
When submitting a PR that can skip ci, use "[citest_skip]" in the PR title.