Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in StreamingSource schema #161

Open
CodeJjang opened this issue Aug 29, 2016 · 1 comment
Open

Improvements in StreamingSource schema #161

CodeJjang opened this issue Aug 29, 2016 · 1 comment
Assignees
Milestone

Comments

@CodeJjang
Copy link
Contributor

  1. sourceType: You can infer the working method from the streamingMethod (VideoStandard 1.0, 0.9 or stanag 4609), but I understood from din that you use it to know whether you receive video or metadata... wouldn't it be better to call it channelType then? Anyway, please make it enum (if it is really chosen from a set of fixed options).

If you need motivation why: I tried to create one today and I didn't know what string to put in.

  1. You can also add validations on the IP and PORT section - they're bug-proned attributes... If I remember right you validated them in your code, but it's more proper to do it before the insertion to DB, just use the custom validations that Mongoose offer...
@motyros
Copy link
Contributor

motyros commented Sep 14, 2016

@dinzone you can use mongoose-validators

@CodeJjang CodeJjang added this to the 0.5 milestone Sep 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants