New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create benchmark for [[likely]] performance #96

Open

uselessgoddess opened this issue Aug 11, 2021 · 1 comment · May be fixed by #91

Labels

Member

uselessgoddess commented Aug 11, 2021

See the new attribute [[likely]]

compare (see this link)

        if (n <= MaximumFactorialNumber)
        {
            return Internal::_factorials[n];
        }
        else
        {
            throw std::out_of_range(std::string("Only numbers from 0 to ").append(std::to_string(MaximumFactorialNumber)).append("are supported by unsigned integer with 64 bits length."));
        }

And

        if (n <= MaximumFactorialNumber) [[likely]]
        {
            return Internal::_factorials[n];
        }
        else [[unlikely]]
        {
            throw std::out_of_range(std::string("Only numbers from 0 to ").append(std::to_string(MaximumFactorialNumber)).append("are supported by unsigned integer with 64 bits length."));
        }

uselessgoddess added the performance label

Member Author

uselessgoddess commented Aug 12, 2021 •

edited

Loading

See this example from godbolt

uselessgoddess linked a pull request

that will close this issue

Translation to C++ #91

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment