Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading documentation on meshing with ingress mode #1837

Open
FredrikAugust opened this issue Sep 3, 2024 · 1 comment
Open

Misleading documentation on meshing with ingress mode #1837

FredrikAugust opened this issue Sep 3, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@FredrikAugust
Copy link

What is the issue?

On the meshing in ingress mode documentation page it reads

When an ingress is meshed in ingress mode, you must configure it to remove the l5d-dst-override header to avoid creating an open relay to cluster-local and external endpoints.

But further down, for Traefik v2, e.g., it tells you to add this header.

I might be reading this wrong, but it seems a bit self-contradictory?

How can it be reproduced?

N/A

Logs, error output, etc

N/A

output of linkerd check -o short

N/A

Environment

N/A

Possible solution

Rewrite the warning alert.

Additional context

No response

Would you like to work on fixing this bug?

None

@FredrikAugust FredrikAugust added the bug Something isn't working label Sep 3, 2024
@wmorgan wmorgan transferred this issue from linkerd/linkerd2 Sep 3, 2024
@wmorgan
Copy link
Member

wmorgan commented Sep 3, 2024

Thanks for filing this. I moved it to the website repo which is where the docs live. I think you're right, the first statement could use a little clarification. Maybe instead of "you must configure it to remove the l5d-dst-override header" we say "you must configure it to strip the l5d-dst-override header from any incoming traffic" ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants