Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect value in the deployment manifest example in the Configuring Proxy Concurrency task page in the Linkerd docs #1808

Open
southsidedean opened this issue Jul 30, 2024 · 0 comments

Comments

@southsidedean
Copy link

On the documentation page for the Configuring Proxy Concurrency task (https://linkerd.io/2.15/tasks/configuring-proxy-concurrency/#), the CLI example is correct, using a proxy-cpu-limit of 2, but the deployment manifest example is incorrect, with a proxy-cpu-limit of 1. Users who set the proxy-cpu-limit to 1 as shown in the deployment example will not have proxy concurrency.

The example manifest from the task page:

kind: Deployment
apiVersion: apps/v1
metadata:
  name: my-deployment
  # ...
spec:
  template:
    metadata:
      annotations:
        config.linkerd.io/proxy-cpu-limit: '1'
  # ...

The page just needs a minor edit to change the proxy-cpu-limit value to 2 in the deployment example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant