Subject: Communication Issue Between Viz and External Prometheus #1659
Conversation
Problem: In the documentation explaining the usage of an external Prometheus, the protocol is missing in provided example. This is causing Viz to be unable to establish communication with the external Prometheus, resulting in a "unsupported protocol" error message in the logs. Solution: added protocol and basic auth to prometheus url Fixes linkerd#1658 Signed-off-by: JadKHaddad <[email protected]>
|
@JadKHaddad, many thanks! and many apologies for letting this linger. 🤦♂️ This looks nice! I've updated this to the latest
Thank you! and, again, I'm sorry for the delay. |
|
@kflynn I'm worried about the heartbeat because it only looks for a Prometheus job called kubernetes-nodes-cadvisor If someone's using a different job name, like cadvisor, it won't work. Should we add the job to the docs? |
|
The example you added looks great, thanks! I think adding the job also sounds like a great idea. |
|
Oh, whoops – any chance you can fix the DCO for your latest, too? 😅 |
JadKHaddad
force-pushed
the
fix_external_prometheus
branch
from
f8734c7
to
d071e99
Compare
Signed-off-by: JadKHaddad <[email protected]>
JadKHaddad
force-pushed
the
fix_external_prometheus
branch
from
d071e99
to
cb7886d
Compare
|
whoops :P Before adding the job to the docs, I want to test the entire workflow again on a fresh Kubernetes cluster. My latest tests were with Linkerd v2.13. |
|
@JadKHaddad Any joy? 🙂 |
|
Hi @kflynn. In version In contrast, on the main branch, it is variable and can be specified through the We can provide all sorts of workarounds in the documentation, like deploying a named service in k8s, but I think this is not what we want to do. Optimally, we wait for the new release which should fix this issue. |
Problem: In the documentation explaining the usage of an external Prometheus, the protocol is missing in provided example. This is causing Viz to be unable to establish communication with the external Prometheus, resulting in a "unsupported protocol" error message in the logs.
Solution: added protocol and basic auth to prometheus url
Fixes #1658