Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs regarding proxy-cpu-limits seem misleading #1495

Open
Fantaztig opened this issue Sep 16, 2022 · 1 comment
Open

Docs regarding proxy-cpu-limits seem misleading #1495

Fantaztig opened this issue Sep 16, 2022 · 1 comment

Comments

@Fantaztig
Copy link

Hi!

The docs regarding the config.linkerd.io/proxy-cpu-limit annotation seem a bit misleading to me.
https://github.com/linkerd/website/blob/main/linkerd.io/content/2.12/tasks/configuring-proxy-concurrency.md

There it is explicitly stated that:

Unlike Kubernetes CPU limits and requests, which can be expressed in milliCPUs, the proxy-cpu-limit annotation should be expressed in whole numbers of CPU cores. Fractional values will be rounded up to the nearest whole number.

I think the last sentence can be removed or rephrased, as specifying e.g. 0.5 as the limit translates perfectly fine into a cpu.limit of "500m" on the containers.
However, I'm not sure if this is intended and documented wrong, if I misunderstood the docs or if it is a bug 😉

@wmorgan
Copy link
Member

wmorgan commented Sep 16, 2022

@kflynn @hawkw any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants