Adding fail-fast feature to fast-serde

[krisso-rtb]

This PR aims to add "fail-fast" feature to the fastserde.

Normally when we have datum writer:

DatumWriter<T> datumWriter = new FastSpecificDatumWriter<>(schema, specificData);

and it's used in a loop as:

datumWriter.write(record, binaryEncoder);

the datumWriter under the hood uses standard avro writer until fast-serializer is generated on the background-thread.

Currently if such generation fails due to any reason we have just one log entry and datumWriter still uses standard avro writer.
We found this approach is sometimes too gentle because it hides an issue for a long time. It's easy to miss one WARN log-entry.

That's why we think "fail-fast" approach would be a nice feature. It can be turned on by setting one of system properties

• avro.fast.serde.failfast
• avro.fast.serde.failfast.supplier

By default it's disabled so that it's backward-compatible.

---

Commits:

1. Code cleanup

• private Optional<String> compileClassPath; changed to private String compileClassPath;
• Resolving compileClassPath extracted to helper method (will be re-used for the new system property)
• other minor things

2. bugfixes

• getFastGenericDeserializerAsync no longer generated StackOverflow (shame on me!)
• Using AvroCompatibilityHelper in fallback-serializers to fix an issue with missing c-tor in Avro 1.4.

3. Generation errors logged on ERROR level.

• We can discuss here - I'm fine with dropping this commit if you think it should stay as WARN.

4. [fastserde] Adding fail-fast feature.

• The main reason why this PR was created.

---

Name "fail-fast" is a kind of industry standard however in this case it may cause confusion with "fast-serde" - we can use another name for this feature (fail-early / force-fastserde / etc.) or give it opposite meaning (e.g. ignore-generation-errors).

[codecov-commenter]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d661ed3) 45.77% compared to head (392f5a9) 45.77%.

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #519      +/-   ##
============================================
- Coverage     45.77%   45.77%   -0.01%     
+ Complexity     4439     4436       -3     
============================================
  Files           403      403              
  Lines         28070    28070              
  Branches       4622     4622              
============================================
- Hits          12850    12848       -2     
  Misses        13664    13664              
- Partials       1556     1558       +2     

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[krisso-rtb]

Hi @FelixGV @gaojieliu
Did you have a chance to look into this?
Just a kind reminder :)

[gaojieliu]

Looks good to me, thanks for the change!

[gaojieliu]

@krisso-rtb
New release:
https://github.com/linkedin/avro-util/releases/tag/0.3.20

[krisso-rtb]

That's awesome!
Thank you!