Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize JSD to FKL/RKL #393

Merged
merged 7 commits into from
Nov 21, 2024
Merged

Generalize JSD to FKL/RKL #393

merged 7 commits into from
Nov 21, 2024

Conversation

yundai424
Copy link
Collaborator

@yundai424 yundai424 commented Nov 18, 2024 •
edited
Loading

Summary

Support beta = 0 and 1 case to support FKL/RKL. This is mostly for conveniently adding FusedLinearF/RKL without introducing too many code duplication.

Testing Done

  • Hardware Type:
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

@yundai424 yundai424 marked this pull request as ready for review November 21, 2024 18:07
@yundai424 yundai424 changed the title [WIP] generalize JSD to FKL/RKL Generalize JSD to FKL/RKL Nov 21, 2024
@yundai424 yundai424 merged commit 998f4e4 into main Nov 21, 2024
3 checks passed
@yundai424 yundai424 deleted the yudai/gen_jsd branch November 21, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingquansong qingquansong qingquansong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yundai424 @qingquansong