Skip to content
This repository has been archived by the owner on Jul 15, 2024. It is now read-only.

Add missing F-key bindings for xkb and Windows. #160

Merged

Conversation

waywardmonkeys
Copy link
Contributor

With keyboard-types 0.7, we have additional F-keys that can be mapped when using xkb.

On Windows, we had not fully added mappings for some F13-F24.

I haven't found scan codes yet for the F25-F35 keys.

With `keyboard-types` 0.7, we have additional F-keys that can be
mapped when using xkb.

On Windows, we had not fully added mappings for some F13-F24.

I haven't found scan codes yet for the F25-F35 keys.
@CryZe
Copy link
Contributor

CryZe commented Aug 20, 2023

Is there evidence that these keys even exist?

@waywardmonkeys
Copy link
Contributor Author

Assuming you mean F25-F35, xkb has stuff for them, winit does as well, and the winit folks asked that these get added to keyboard-types.

My keyboards are (apparently) rather dull and don't have anything past F12.

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

These keys are useful for applications like keyboard remappers, as otherwise useless keys to communicate between applications. For an example, see https://youtu.be/lIFE7h3m40U?t=983 (Tom Scott - The Art of the Bodge: How I Made The Emoji Keyboard at ~16:23)

I personally use the F15 key as a global shortcut for discord's push to talk, to allow the use of a mouse button for this purpose

@waywardmonkeys waywardmonkeys added this pull request to the merge queue Aug 20, 2023
@waywardmonkeys
Copy link
Contributor Author

In trying some things out, I've found at least a couple of bugs in other code in Glazier ...

Merged via the queue into linebender:main with commit a54d50a Aug 20, 2023
7 checks passed
@waywardmonkeys waywardmonkeys deleted the missing-fkey-mappings branch August 21, 2023 00:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants