This repository has been archived by the owner on Jul 15, 2024. It is now read-only.
windows: Use Rc with HCURSOR.
#146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's unfortunate to lose We do need a test that Cursor is consistently not Send (i.e. on all platforms), like we have for |
|
As discussed during office hours, let's move this forward to satisfy clippy and I'll document the lack of Next steps:
|
The `Cursor` isn't `Send` / `Sync`, so this can just use `Rc`. Since `HCURSOR` isn't `Send` / `Sync`, it wasn't valid to use `Arc` with it. This generates a clippy warning starting in Rust 1.72. Fixes linebender#138.
waywardmonkeys
force-pushed
the
windows-rc-hcursor
branch
from
d473413
to
fb3c722
Compare
|
Rebased, force-pushed, and marked as ready for review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Cursorisn'tSend/Sync, so this can just useRc.Since
HCURSORisn'tSend/Sync, it wasn't valid to useArcwith it. This generates a clippy warning starting in Rust 1.72.Fixes #138.