-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: Add "top" option #499
Comments
I don't quite understand the implications, but I'm absolutely happy to look at a PR (or read more of an explanation regarding what it does) |
If you use this dialog in a facebook canvas app, you need a code like this:
otherwise your dialog will be shown on the top of the page even if you scrolled the page down. |
I'm now open to a PR for this, looks like a useful feature. Please include a unit test to prove it works? |
Hi,
since I had problem with using this module inside a facebook canvas app, I added the "top" option to the module on my own.
I wanna ask you if you can do it on the repository, cause I think it can be a good feature in some environments.
The text was updated successfully, but these errors were encountered: