Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Add "top" option #499

Open
giacomomasseron opened this issue Aug 4, 2016 · 3 comments · May be fixed by #590
Open

FEATURE: Add "top" option #499

giacomomasseron opened this issue Aug 4, 2016 · 3 comments · May be fixed by #590

Comments

@giacomomasseron
Copy link

Hi,
since I had problem with using this module inside a facebook canvas app, I added the "top" option to the module on my own.
I wanna ask you if you can do it on the repository, cause I think it can be a good feature in some environments.

@faceleg
Copy link
Contributor

faceleg commented Aug 26, 2016

I don't quite understand the implications, but I'm absolutely happy to look at a PR (or read more of an explanation regarding what it does)

@giacomomasseron
Copy link
Author

giacomomasseron commented Aug 26, 2016

If you use this dialog in a facebook canvas app, you need a code like this:

FB.Canvas.getPageInfo(
    function(info) {
        ngDialog.open({
            template: response.data.html,
            plain: true,
            className: 'ngdialog-theme-default',
            top: info.scrollTop + 'px',
            scope: $scope });
    }
);

otherwise your dialog will be shown on the top of the page even if you scrolled the page down.

@faceleg
Copy link
Contributor

faceleg commented Aug 28, 2016

I'm now open to a PR for this, looks like a useful feature.

Please include a unit test to prove it works?

@freedomlang freedomlang linked a pull request May 23, 2018 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants