Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

watchtowers: warn or disallow users from connecting the the wt server running on the same node as the wtclient #5522

Open
xanoni opened this issue Jul 15, 2021 · 6 comments · May be fixed by #9230
Open

watchtowers: warn or disallow users from connecting the the wt server running on the same node as the wtclient #5522

xanoni opened this issue Jul 15, 2021 · 6 comments · May be fixed by #9230
Labels
beginner Issues suitable for new developers enhancement Improvements to existing features / behaviour watchtower

Comments

@xanoni
Copy link
Contributor

xanoni commented Jul 15, 2021

Background

  1. I noticed that I can connect a node to its own watchtower, and it even starts backing up. Maybe we should warn users somehow that this is not how it's supposed to be done?

  2. When I first set up watchtowers I didn't realize that the PubKey / onion address was different from the actual LND node itself ... however, it still let me connect and lncli wtclient towers shows them as valid watchtowers ... wouldn't it be better if the client rejected pubkeys/addresses that are not watchtowers, or at least indicate that something is broken?

image

  1. What's the reason in the first place that the pubkey and address of the watchtower have to differ from the main node? Is this just a safety measure while the feature is being tested by volunteers?

Thank you (leaving the stuff below so the bot doesn't punish me for ignoring the template).

Your environment

  • version of lnd
  • which operating system (uname -a on *Nix)
  • version of btcd, bitcoind, or other backend
  • any other relevant environment details

Steps to reproduce

Tell us how to reproduce this issue. Please provide stacktraces and links to code in question.

Expected behaviour

Tell us what should happen

Actual behaviour

Tell us what happens instead
@xanoni
Copy link
Contributor Author

xanoni commented Jul 15, 2021

Saw that point 2 is also addressed here: #5361

@ellemouton
Copy link
Collaborator

Hi @xanoni !

First of all, good point: there should definitely be a warning or it should strictly disallow users from connecting to their own binary.

Secondly, the reason for the main node ID not being used is to maintain privacy. We want to be able to use a watch tower without giving away what our main node ID is.

@ellemouton ellemouton added watchtower enhancement Improvements to existing features / behaviour labels Aug 18, 2022
@ellemouton ellemouton changed the title watchtower (wtclient) usability questions watchtowers: warn or disallow users from connecting the the wt server running on the same node as the wtclient Aug 18, 2022
@Chinwendu20
Copy link
Contributor

Please I would like to work on this issue

@ellemouton ellemouton added the beginner Issues suitable for new developers label Jul 19, 2023
@anibilthare
Copy link
Contributor

@ellemouton I need your help, I tried to implement this but I'm not able to test my changes as my wtclient add call gets stuck.

lnd node output
Screenshot 2024-10-26 at 7 05 44 PM

lncli add call
Screenshot 2024-10-26 at 7 07 19 PM

@ellemouton
Copy link
Collaborator

@anibilthare - it just looks like your node isnt synced. If you are on regtest, try mining a few blocs

(also just for future: if you want to share a really large piece of text like the config file above, consider adding a link to the text instead as it takes a lot of space on this page)

@anibilthare
Copy link
Contributor

Hi, Thanks. Yeah mining worked. Thanks.

Yeah I'll keep that in mind.

@anibilthare anibilthare linked a pull request Oct 29, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner Issues suitable for new developers enhancement Improvements to existing features / behaviour watchtower
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

wtclientrpc: prevent watchtower connections to local addresses anibilthare/lnd
4 participants
@ellemouton @anibilthare @Chinwendu20 @xanoni