Interpret sync_complete in reply_channel_range #790
Conversation
LN Spec PR lightningdevkit#826 changes full_information to indicate completion of a sequence of reply_channel_range messages.
Codecov Report
@@ Coverage Diff @@
## main #790 +/- ##
==========================================
- Coverage 90.79% 90.78% -0.02%
==========================================
Files 38 38
Lines 23168 23157 -11
==========================================
- Hits 21036 21023 -13
- Misses 2132 2134 +2
Continue to review full report at Codecov.
|
|
|
| action: ErrorAction::IgnoreError, | ||
| }); | ||
| } | ||
| log_debug!(self.logger, "Handling reply_channel_range peer={}, first_blocknum={}, number_of_blocks={}, sync_complete={}, scids={}", log_pubkey!(their_node_id), msg.first_blocknum, msg.number_of_blocks, msg.sync_complete, msg.short_channel_ids.len(),); |
There was a problem hiding this comment.
Okay if I follow correctly, the fact we're stateless means we can't qualify if the range is effectively complete and sync_complete sets properly. But we don't care as peer was able to equivocate before, logging is best we can do.
There was a problem hiding this comment.
Right - we don't care if a given message indicates the end or not - we just respond to them as they come in.
Addresses changes to
reply_channel_rangeper point 1 of lightning/bolts#826This PR
full_informationtosync_completefull_information=falseas a failure response