Add verification that all CI steps were executed

Adds a --verify-complete flag to ci-tests.sh that checks all steps
defined in ALL_STEPS were actually run. Each step logs its completion
to GITHUB_ENV, and a final verification step ensures nothing was
missed. This prevents CI steps from being silently skipped if the
workflow and script get out of sync.

Co-Authored-By: Claude Opus 4.5 <[email protected]>

Author: joostjager

.github/workflows/build.yml

@@ -142,6 +142,9 @@ jobs:
       - name: Test cfg-flag builds
         shell: bash
         run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh test-cfg-flags
+      - name: Verify all CI steps ran
+        shell: bash
+        run: ./ci/ci-tests.sh --verify-complete
 
   coverage:
     needs: fuzz

ci/ci-tests.sh

@@ -55,6 +55,22 @@ fi
 
 WORKSPACE_MEMBERS=( $(cat Cargo.toml | tr '\n' '\r' | sed 's/\r    //g' | tr '\r' '\n' | grep '^members =' | sed 's/members.*=.*\[//' | tr -d '"' | tr ',' ' ') )
 
+# Verify that all steps were executed (called at the end of CI)
+if [ "$1" = "--verify-complete" ]; then
+	MISSING_STEPS=""
+	for STEP in $ALL_STEPS; do
+		if [[ ! " $CI_COMPLETED_STEPS " == *" $STEP "* ]]; then
+			MISSING_STEPS="$MISSING_STEPS $STEP"
+		fi
+	done
+	if [ -n "$MISSING_STEPS" ]; then
+		echo "ERROR: The following CI steps were not executed:$MISSING_STEPS"
+		exit 1
+	fi
+	echo "All CI steps were executed successfully."
+	exit 0
+fi
+
 for STEP in $STEPS_TO_RUN; do
 case "$STEP" in
 
@@ -222,4 +238,9 @@ exit 1
 ;;
 
 esac
+
+# Log the completed step to GITHUB_ENV for the verification step
+if [ -n "$GITHUB_ENV" ]; then
+	echo "CI_COMPLETED_STEPS=${CI_COMPLETED_STEPS:-} $STEP" >> "$GITHUB_ENV"
+fi
 done