Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make docLinks only visible for logged users #834

Open
victorvalle opened this issue Nov 3, 2020 · 5 comments
Open

Make docLinks only visible for logged users #834

victorvalle opened this issue Nov 3, 2020 · 5 comments
Labels

Comments

@victorvalle
Copy link

A few days ago we created docLinks to internal documentation in Drive. I'm receiving a ton of requests from outsiders to these links.

Would it be possible to show them just for logged users as they point to internal documentation?

@victorvalle
Copy link
Author

@plhnk can you send me an example so I can do it? please :)

@plhnk
Copy link
Member

plhnk commented Nov 3, 2020

Hahaha hm... this is a little tough. Currently we only have PrivatePage — but I feel like it wouldn't be too difficult to make something like PrivateComponent using similar logic?

I've had similar thoughts recently about opening up the blueprints site, but restricting only the content, not the navigation.

Thinking aloud — PrivateComponent would show data if user is logged in, otherwise would display a 🔒...hovering (or clicking) would display a tooltip that says something like "for Liferay employees only, log in to view this content".

Thoughts? Other ideas?

@victorvalle
Copy link
Author

I was just planning on a show/hide content based on user status.

In our case, that barrier is set by Google Drive. It will request you to log with a user account. But any of us who created a document will be receiving emails requesting to check internal documentation.

I find your solution good as it will show the path to employees :)

plhnk added a commit to plhnk/liferay.design that referenced this issue Nov 5, 2020
plhnk added a commit that referenced this issue Dec 14, 2020
plhnk added a commit that referenced this issue Dec 14, 2020
plhnk added a commit that referenced this issue Dec 14, 2020
@victorvalle
Copy link
Author

Can we consider this done @plhnk ?

@plhnk
Copy link
Member

plhnk commented Feb 11, 2021

@victorvalle — sorry I never logged my thoughts, I want to add a tooltip to the component that will make it easier for people to understand what the lock means and what action to take next — this requires:

  • refactoring the AuthContainer and LogoutContainer — abstracting the styling out
  • refactoring the places where the above are used — PrivatePage and in the Nav
  • creating the ToolTip style in theme-ui/components
  • implementing the tooltip in the page

So — thats why I haven't closed it yet, a bit of yak-shaving to be done yet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants