Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't assign MANAGE_NODE_OPERATOR_ROLE to voting upon scratch deploy #813

Open
arwer13 opened this issue Nov 28, 2023 · 1 comment
Open

Don't assign MANAGE_NODE_OPERATOR_ROLE to voting upon scratch deploy #813

arwer13 opened this issue Nov 28, 2023 · 1 comment

Comments

@arwer13
Copy link
Contributor

arwer13 commented Nov 28, 2023

Assigning the role to Voting was introduced in #807 to skip adding voting-related code to scripts/scratch/checks/scratch-acceptance-test.js

The plan is to remove assigning the role after voting-related code is available at https://github.com/lidofinance/periphery/ and can be reused.
@arwer13 arwer13 mentioned this issue Nov 28, 2023
Merged
@TheDZhon
Copy link
Contributor

TheDZhon commented Nov 29, 2023 •
edited
Loading

The role is assigned permanently to Agent on Mainnet (see: https://vote.lido.fi/vote/162). Shall we preserve this case?

NB: the same is true for REQUEST_BURN_MY_STETH_ROLE

@mymphe mymphe mentioned this issue Sep 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheDZhon @arwer13