Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why the versions of OS and gcc in build_python.yml are old? #199

Closed
zaikunzhang opened this issue Apr 30, 2024 · 2 comments
Closed

Why the versions of OS and gcc in build_python.yml are old? #199

zaikunzhang opened this issue Apr 30, 2024 · 2 comments
Labels
ci Issues related to CI python Issues related to the Python interface or implementation

Comments

@zaikunzhang
Copy link
Member

zaikunzhang commented Apr 30, 2024

Hi @nbelakovski ,

Is it intended that we use older versions of OS (instead of latest) and gcc 8 (for macOS, very old) in

https://github.com/libprima/prima/blob/main/.github/workflows/build_python.yml

In addition, we need to cover macOS ARM64, currently available under GitHub Actions with macos-14 runners.

Thank you.

Zaikun

@zaikunzhang zaikunzhang added python Issues related to the Python interface or implementation ci Issues related to CI labels Apr 30, 2024
@nbelakovski
Copy link
Contributor

Some of the code there was copied from https://github.com/scipy/scipy/blob/main/.github/workflows/wheels.yml, particularly the rtools part, which installed gcc8, and hence why I used gcc8 elsewhere.

As for the OS versions, it looks like I copied from the cibuildwheels docs, specifically this one, which currently uses -latest for Windows/Linux and more recent versions for MacOS, but a couple months ago, when I wrote this file, it was showing the older versions, so I decided to just copy in case it wasn't yet working on that latest builds.

If the versions can be safely updated I see no reason why not.

@zaikunzhang
Copy link
Member Author

zaikunzhang commented May 1, 2024

Hi @nbelakovski ,

Wheels are built on newer OS with newer gcc now using the new yml and the following changes:

c44deb8..7a49bb6b (compare)

I hope this is fine with you.

However, Python wheel testing fails on macOS 14 (ARM64). See

#201

Thanks.

Zaikun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Issues related to CI python Issues related to the Python interface or implementation
Projects
None yet
Development

No branches or pull requests

2 participants