-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test cmake and c interface with PRIMA_REAL_PRECISION
being in [32, 64, 128], PRIMA_INTEGER_KIND
being in [16, 32, 64], and PRIMA_DEBUGGING
being in [0, 1]
#129
Comments
PRIMA_REAL_PRECISION
being in [32, 64, 128], PRIMA_INTEGER_KIND
being in [16, 32, 64], and PRIMA_DEBUGGING
being in [0, 1]
Since the C interface has been written with |
This will be nice, but I don't think it is a must for the time being if it takes too much effort. For the moment, we only need to test. If someone wants RP to be different from the default value, he can modify
First of all, if a piece of code fails to compile when we change some macros to some non-default but correct values, then the code is wrong. It is logically wrong to assume that RP corresponds to double precision. Secondly, Thirdly, indeed, double precision does not necessarily correspond to Thank you. |
The MATLAB interface provides two options I do hope that other interfaces can do the same one day, which will take some effort but it is doable, as I have done in MATLAB. Before that day comes, users can modify BTW, PRIMA will gradually unveil its complexity when you know it more. Enjoy! :) |
The Fortran code allows
REAL(RP)
to be different from 64-bit real, andINTEGER(IK)
to be different from 32-bit integer. This can be done by settingPRIMA_REAL_PRECISION
andPRIMA_INTEGER_KIND
infortran/common/ppf.h
.We should make sure that the cmake and c interface (or any other interface) still work if we vary these values from the default.
In addition, PRIMA_DEBUGGING in ppf.h controls whether the Fortran code is in the debug mode, which enables checking of pre/postconditions in the Fortran code. This should also be tested.
Moreover, PRIMA does not tolerate any warning. This has been achieved by the Fortran code. The standard should be maintained by any other interface and implementation.
@nbelakovski , we discussed this before. Could you have a look? Thanks.
The text was updated successfully, but these errors were encountered: