New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gradle-build action contains a hard-wired Java "distribution" value #191

Open

ModeSevenIndustrialSolutions opened this issue Oct 23, 2024 · 0 comments

Labels

Contributor

ModeSevenIndustrialSolutions commented Oct 23, 2024

I think this step might need some attention:

    - name: Setup JDK
      id: setup-jdk
      uses: actions/setup-java@v3
      with:
        java-version: ${{ inputs.jdk-version }}
        distribution: "temurin"

Distribution is required, but could have multiple values, as per the documentation:
https://github.com/actions/setup-java?tab=readme-ov-file#supported-distributions

Might be better to set this in an optional input, with "temurin" as default value?

The text was updated successfully, but these errors were encountered:

ModeSevenIndustrialSolutions added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment