Skip to content
This repository has been archived by the owner on Sep 7, 2024. It is now read-only.

shoot.wav,invaderkilled.wav #29

Open
dauuricus opened this issue Dec 23, 2019 · 4 comments
Open

shoot.wav,invaderkilled.wav #29

dauuricus opened this issue Dec 23, 2019 · 4 comments

Comments

@dauuricus
Copy link

Thanks, I used your code as a starting point for learning python. I think it has a very beautiful structure.

Are the file names of these two files reversed?

  • shoot.wav
  • invaderkilled.wav

https://youtu.be/_2yUP3WMDRc?t=76

A version in which two file names are swapped
https://youtu.be/3bptgz5M-Xk

@leerob
Copy link
Owner

leerob commented Dec 23, 2019

Hey @dauuricus, I'm glad it was helpful!

Could you try running it locally and seeing if the correct sounds are fired?

@dauuricus
Copy link
Author

dauuricus commented Dec 25, 2019

I think your invadergame program is best for leaning to write a invadergame like program in python.
Thank you :)

I think that shoot.wav is "invaderkilled.wav" and invaderkilled sound is player 's laser shoot sound.

This is maybe original invaders2 version.You can hear player's laser shoot sound and invaderkilled sound.
https://youtu.be/kR2fjwr-TzA

This is my swapped 2 files version.
https://youtu.be/aowPKIgQCXc

This is my dirty soruce code.WIP...
https://gist.github.com/dauuricus/56be1d1c26914177e7b213aa5f56d157

I just changed original file name like
shoot.wav to invaderkilled.wav,
invaderkilled.wav to shoot.wav.
https://gist.github.com/dauuricus/56be1d1c26914177e7b213aa5f56d157

@leerob
Copy link
Owner

leerob commented Dec 26, 2019

@leerob
Copy link
Owner

leerob commented Dec 26, 2019

Oh, you're asking about your own branch. I took a look and nothing sticks out to me at first glance.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants