Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support comma delimiters in amount field of send form #1152

Open
markmhendrickson opened this issue Jan 15, 2023 · 3 comments
Open

Support comma delimiters in amount field of send form #1152

markmhendrickson opened this issue Jan 15, 2023 · 3 comments
Labels
Enhancement 💡 Functionality needed or wanted by users P3 Enhancement ✨ Non-critical functionality wanted by many users, or there are clear alternatives

Comments

@markmhendrickson
Copy link
Collaborator

Screenshot 2023-01-15 at 14 17 52

@markmhendrickson markmhendrickson added Enhancement 💡 Functionality needed or wanted by users P3 Enhancement ✨ Non-critical functionality wanted by many users, or there are clear alternatives labels Jan 15, 2023
@kyranjamie
Copy link
Collaborator

kyranjamie commented Jan 15, 2023

I'd hold off doing this until we localise the wallet properly. To many, this is 5.210 which adds an ambiguity that isn't there with no delimiter at all.

@markmhendrickson
Copy link
Collaborator Author

Are there English locales that treat the comma as a decimal? If so, I'd agree let's wait. Though if not, it seems consistent with the default language?

@314159265359879
Copy link

I would prefer not using delimiting like this, it just leads to confusion and mistakes. Only use . and , as decimal mark

If you want to improve readability use space for delimiting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement 💡 Functionality needed or wanted by users P3 Enhancement ✨ Non-critical functionality wanted by many users, or there are clear alternatives
Projects
None yet
Development

No branches or pull requests

3 participants