Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept docx and doc files #384

Open
AtKristijan opened this issue Aug 19, 2022 · 3 comments
Open

Accept docx and doc files #384

AtKristijan opened this issue Aug 19, 2022 · 3 comments

Comments

@AtKristijan
Copy link
Contributor

AtKristijan commented Aug 19, 2022

  • ricecooker version:
  • Python version:
  • Operating System:

Description

Currently what i find out is that our last version of ricecooker ( develop branch ) do not support doc files. So we got one repo that can convert them but the problem is that you need to start docker and send post method to this service. Also this means that first you need to download all files and then convert it and then put it in ricecooker node > files.

What my Idea is:

What my idea is to use function in ricecooker with flag that if flag is True to convert files from one extension to another. And this to be made automatically in ricecooker without downloading first files locally and then to convert it.

In this function we need to implemented this new idea.
Files > write_path_to_filename or in download.

@rtibbles
Copy link
Member

I think it would be good to detail how we would configure the doc/docx conversion service.

I think the assumption here is that there might be an instance of the learningequality/microwave service running on an accessible IP address (either online or locally) - so if you used a File of this kind, it would check if this service was available and otherwise fail.

Because we can't use the file type without this conversion, I don't think the option to convert is necessary, this WordFile class would just always try to convert?

@AtKristijan
Copy link
Contributor Author

There is 2 options that i will explore.

  1. To see if i can put whole microwave service inside ricecooker without need of starting it as service
  2. To make health check and each developer will need to take care of starting the service locally and setup the path so ricecooker can access it. If ricecooker do not have access will fail or will ignore the files all depends how strict we want to make it.

@rtibbles
Copy link
Member

I think 1) might be too difficult to achieve within the confines of a Python package, but definitely worth a little bit of investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants