Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typing_extensions #12610

Open
jredrejo opened this issue Aug 27, 2024 · 4 comments
Open

Update typing_extensions #12610

jredrejo opened this issue Aug 27, 2024 · 4 comments
Labels
TAG: tech update / debt Change not visible to user

Comments

@jredrejo
Copy link
Member

Overview

Kolibri 0.17 has in its bundled packages typing_extensions version 4.1.1
This version is blocking KDP to upgrade Altair library which requires typing_extensions >= 4.9

Description and outcomes

Not sure why kolibri is providing this library as it does not use python hints, so, I think it should not be a problem upgrading it. When writing this issue, last available version is 4.12.1

@jredrejo jredrejo added the TAG: tech update / debt Change not visible to user label Aug 27, 2024
@rtibbles
Copy link
Member

This must be a dependency of another dependency, as we have not hard coded this anywhere.

@rtibbles
Copy link
Member

Typing extensions only supports Python 3.8 plus, so we won't be able to bundle the required version for this in Kolibri.

This would have to be addressed by having a wheel file that does not statically bundle dependencies.

@marcellamaki
Copy link
Member

@jredrejo - is not upgrading Altair library preventing something in particular that you are working on or plan to work on? or is this more general? (I did a quick skim of the related dependabot upgrade and didn't see any particular security vulnerabilities, etc.). I don't think this could be done before 0.18 but just want to make sure I have the context about what this upgrade will enable, if anything beyond good maintenance and staying up to date.

@jredrejo
Copy link
Member Author

jredrejo commented Aug 28, 2024

@marcellamaki
main reason to upgrade was the bugs Altair 5.4 fixes, but we can live with 5.3 as we don't have news of its bugs affecting us. For the new features we don't plan to use them yet. Another reason to update would be that it syncs with the last vega-lite (JavaScript counterpart of this library),

On a side note, getting rid of Vega is part of the KDP tech debt that I'd like to work in the medium term. Switching to a browser-only charting library will release resources in the server and will make sharing tasks betweeen developers far easier.

So, in summary:
unless we discover new bugs, don't worry too much with this. We can live with current Vega version in KDP. I've just lowered the importance of this issue. Feel free to move it to another milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TAG: tech update / debt Change not visible to user
Projects
None yet
Development

No branches or pull requests

3 participants