-
Notifications
You must be signed in to change notification settings - Fork 647
-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update typing_extensions #12610
Comments
This must be a dependency of another dependency, as we have not hard coded this anywhere. |
Typing extensions only supports Python 3.8 plus, so we won't be able to bundle the required version for this in Kolibri. This would have to be addressed by having a wheel file that does not statically bundle dependencies. |
@jredrejo - is not upgrading Altair library preventing something in particular that you are working on or plan to work on? or is this more general? (I did a quick skim of the related dependabot upgrade and didn't see any particular security vulnerabilities, etc.). I don't think this could be done before 0.18 but just want to make sure I have the context about what this upgrade will enable, if anything beyond good maintenance and staying up to date. |
@marcellamaki On a side note, getting rid of Vega is part of the KDP tech debt that I'd like to work in the medium term. Switching to a browser-only charting library will release resources in the server and will make sharing tasks betweeen developers far easier. So, in summary: |
Overview
Kolibri 0.17 has in its bundled packages typing_extensions version 4.1.1
This version is blocking KDP to upgrade Altair library which requires typing_extensions >= 4.9
Description and outcomes
Not sure why kolibri is providing this library as it does not use python hints, so, I think it should not be a problem upgrading it. When writing this issue, last available version is 4.12.1
The text was updated successfully, but these errors were encountered: