Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'notify_team_new_comment' GitHub action to ignore comments by the Sentry bot #12568

Open
MisRob opened this issue Aug 16, 2024 · 0 comments
Labels
github_actions Pull requests that update GitHub Actions code TAG: dev experience Build performance, linting, debugging...

Comments

@MisRob
Copy link
Member

MisRob commented Aug 16, 2024

Summary

Update 'notify_team_new_comment' GitHub action to ignore comments by the Sentry bot

Observed behavior

The GitHub action that sends a Slack notification when a contributor comments on issue, .github/workflows/notify_team_new_comment.yml, sends us notifications for comments by the Sentry bot sentry-io[bot]:

Screenshot from 2024-08-16 19-54-33

Related comment: learningequality/studio#4643 (comment)

Expected behavior

notify_team_new_comment is updated so that we don't receive notifications from sentry-io[bot].

Comments

Unless #12567 is resolved at first, note that copies of this action need to be updated in the same way in the following repositories:

  • Studio
  • Kolibri Design System
    • Even though strictly speaking we're not receiving comments from Sentry there, it'll be good to keep them consistent because of the plan to make it into a re-usable action
@MisRob MisRob added TAG: dev experience Build performance, linting, debugging... github_actions Pull requests that update GitHub Actions code labels Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code TAG: dev experience Build performance, linting, debugging...
Projects
None yet
Development

No branches or pull requests

1 participant