Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make _useKResponsiveElement composable public and Remove KResponsiveElementMixin #711

Open
AlexVelezLl opened this issue Aug 1, 2024 · 3 comments
Assignees
Labels
Component: KResponsiveElementMixin help wanted Open source contributors welcome P2 - normal Priority: Nice to have TAG: dev experience type: task Something that needs to be done

Comments

@AlexVelezLl
Copy link
Member

Product

KDS, Kolibri (Studio and KDP doesnt seem to be using the KResponsiveElementMixin).

Description

Transition the internal composable _useKResponsiveElement to a public-facing composable named useKResponsiveElement. Then, remove the KResponsiveElementMixin mixin from the codebase. This involves the following steps:

  • Rename _useKResponsiveElement.js file to useKResponsiveElement.js.
  • Update all internal references to use the new file name.
  • Migrate all internal references of KResponsiveElementMixin to use the new useKResponsiveElement composable.
  • Remove the KResponsiveElementMixin.js file.
  • Create a new documentation page for useKResponsiveElement.
  • Remove the old documentation page of KResponsiveElementMixin.

The Value Add

After this, we will able to replace all KResponsiveElement mixins with this composable. This aligns with our plan of adopting composables over mixins.

@lokesh-sagi125
Copy link
Contributor

hi, @AlexVelezLl can you assign this issue to me?

@MisRob
Copy link
Member

MisRob commented Aug 20, 2024

Hey @lokesh-sagi125, I think the issue is suitable for contribution, however @AlexVelezLl assigned himself some time ago so I'm not sure if there's some work in progress. Let's hear from Alex first where things are.

@AlexVelezLl
Copy link
Member Author

Hey @lokesh-sagi125! This issue is already assigned to me, and I have already made some progress 😅. But you can always check our list of unassigned "help wanted" or "good first issue" issues across all our repositories 👐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: KResponsiveElementMixin help wanted Open source contributors welcome P2 - normal Priority: Nice to have TAG: dev experience type: task Something that needs to be done
Projects
None yet
Development

No branches or pull requests

3 participants