Skip to content

Commit d68ba72

Browse files
refactor: rename ignored instances to ignored types
1 parent 07cbef8 commit d68ba72

File tree

1 file changed

+9
-15
lines changed

1 file changed

+9
-15
lines changed

packages/leancode_lint/lib/lints/avoid_missing_dispose.dart

Lines changed: 9 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -11,34 +11,34 @@ import 'package:custom_lint_builder/custom_lint_builder.dart';
1111
import 'package:leancode_lint/utils.dart';
1212
import 'package:yaml/yaml.dart';
1313

14-
class _IgnoredInstance {
15-
const _IgnoredInstance({required this.name, required this.packageName});
14+
class _IgnoredTypes {
15+
const _IgnoredTypes({required this.name, required this.packageName});
1616

1717
final String name;
1818
final String packageName;
1919
}
2020

2121
class AvoidMissingDisposeConfig {
2222
const AvoidMissingDisposeConfig({
23-
this.ignoredInstances = const {},
23+
this.ignoredTypes = const {},
2424
this.ignoredInstancesCheckers = const [],
2525
});
2626

2727
factory AvoidMissingDisposeConfig.fromConfig(Map<String, YamlList?> json) {
28-
final ignoredInstances =
28+
final ignoredTypes =
2929
json['ignored_instances']?.nodes
3030
.map(
31-
(e) => _IgnoredInstance(
31+
(e) => _IgnoredTypes(
3232
name: (e as YamlMap)['ignore'] as String,
3333
packageName: e['from_package'] as String,
3434
),
3535
)
3636
.toSet() ??
3737
const {};
3838
return AvoidMissingDisposeConfig(
39-
ignoredInstances: ignoredInstances,
39+
ignoredTypes: ignoredTypes,
4040
ignoredInstancesCheckers: [
41-
for (final _IgnoredInstance(:name, :packageName) in ignoredInstances)
41+
for (final _IgnoredTypes(:name, :packageName) in ignoredTypes)
4242
if (packageName.startsWith('dart:'))
4343
TypeChecker.fromUrl('$packageName#$name')
4444
else
@@ -47,7 +47,7 @@ class AvoidMissingDisposeConfig {
4747
);
4848
}
4949

50-
final Set<_IgnoredInstance> ignoredInstances;
50+
final Set<_IgnoredTypes> ignoredTypes;
5151
final List<TypeChecker> ignoredInstancesCheckers;
5252
}
5353

@@ -199,13 +199,7 @@ class AvoidMissingDispose extends DartLintRule {
199199
ConstructorDeclaration? _getConstructorDeclaration(
200200
ClassDeclaration classNode,
201201
) {
202-
return classNode.members.firstWhereOrNull(
203-
(member) => switch (member) {
204-
final ConstructorDeclaration _ => true,
205-
_ => false,
206-
},
207-
)
208-
as ConstructorDeclaration?;
202+
return classNode.members.whereType<ConstructorDeclaration>().firstOrNull;
209203
}
210204

211205
ClassDeclaration? _getContainingClass(AstNode node) {

0 commit comments

Comments
 (0)