Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set peakfinder min_sep based on bin width(s) #270

Open
jvavrek opened this issue May 6, 2021 · 1 comment
Open

Set peakfinder min_sep based on bin width(s) #270

jvavrek opened this issue May 6, 2021 · 1 comment

Comments

@jvavrek
Copy link
Contributor

jvavrek commented May 6, 2021

From #263, it would be useful to set the min_sep in the peak finder based on the bin width. The complication here is accounting for non-uniform bins—we'll need to look up the bin width of a prospective peak, rather than just use e.g. spec.bin_widths_raw.min()

@jvavrek
Copy link
Contributor Author

jvavrek commented Sep 1, 2021

Could handle the uniform case automatically, and warn/error if the bins are non-uniform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant