Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw Exceptions instead of triggering Errors/Warninings #52

Open
staabm opened this issue Apr 6, 2017 · 3 comments
Open

Throw Exceptions instead of triggering Errors/Warninings #52

staabm opened this issue Apr 6, 2017 · 3 comments

Comments

@staabm
Copy link
Contributor

staabm commented Apr 6, 2017

Would be great when tain could be configured (e.g. using taint.error_level) to throw proper Exceptions instead of triggering Errors/Warnings.

That way would would have a proper backtrace and localisation of the actual errors would be way easier.

@laruence
Copy link
Owner

laruence commented Apr 7, 2017

make sense.... I will do it later, or if you are interesting in it, you could do a PR ;) thanks

@staabm
Copy link
Contributor Author

staabm commented Apr 7, 2017

my C fu is very limited.. I try to learn but atm I cannot help you with things like this, sorry

@staabm
Copy link
Contributor Author

staabm commented Apr 13, 2017

I changed the way I integrate the extension with my code, so having it throw a Exception will no longer provide benefit for me. therefore we could close this issue.

my new approach is

  • register a error handler which turns taint-warnings into exceptions
  • in the error handler I filter out taint-errors from files which are not under my control (e.g. external dependencies etc.) as those need to be handled differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants