You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Our BConv op has a few parameter combinations where it can throw during Init or Prepare. In the converter we try to make sure that none of those cases will ever occur, but it would be good to add verification code so that potential errors are already caught during conversion and not at runtime which makes for a much nicer user experience if something goes wrong (especially when relying one some of our experimental features).
Most of the verification is already autogenerated by MLIR based on the attr constraints, but we also have some unsupported cases that depend on the interaction between different attributes [e.g. padding and fused activation functions).
This verification can be done nicely by populating the following verifier boilerplate with the relevant constraints of our TFLite kernel:
Since #384 we can make use of the IR verification features of MLIR.
Our BConv op has a few parameter combinations where it can throw during
Init
orPrepare
. In the converter we try to make sure that none of those cases will ever occur, but it would be good to add verification code so that potential errors are already caught during conversion and not at runtime which makes for a much nicer user experience if something goes wrong (especially when relying one some of our experimental features).Most of the verification is already autogenerated by MLIR based on the attr constraints, but we also have some unsupported cases that depend on the interaction between different attributes [e.g. padding and fused activation functions).
This verification can be done nicely by populating the following verifier boilerplate with the relevant constraints of our TFLite kernel:
I am labeling this as a "good first issue" since it is a well scoped problem and we are happy to assist if anyone wants to tackle this.
The text was updated successfully, but these errors were encountered: