Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move connection parameters to phpunit env #132

Closed
ArthurPatriot opened this issue Apr 5, 2024 · 2 comments
Closed

Move connection parameters to phpunit env #132

ArthurPatriot opened this issue Apr 5, 2024 · 2 comments
Assignees

Comments

@ArthurPatriot
Copy link
Contributor

ArthurPatriot commented Apr 5, 2024

Hello guys. What you think about to move all connections parameters to phpunit env. For example, I want to test reverb on windows machine, windows doesn't support creating socket connection on 0.0.0.0, I must use local ip. And now, I must add host parameter to each test where present host...

Will be easy to get this parameters from env ($host, $port, $appId). And code will be more clean and reusable. What you think?

@joedixon joedixon self-assigned this Apr 5, 2024
@joedixon
Copy link
Collaborator

joedixon commented Apr 5, 2024

I think it's nice to have the option to spin up multiple servers on different hosts, but I don't think I'm against defaulting to the phpunit environment.

@joedixon
Copy link
Collaborator

Would welcome a PR for this, but closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants