Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component emitted event "edit" but it is neither declared in the emits option nor as an "onEdit" prop. #414

Closed
4 tasks done
mauthi opened this issue Feb 26, 2022 · 2 comments

Comments

@mauthi
Copy link
Contributor

mauthi commented Feb 26, 2022

This is a bug.

Prerequisites

  • Are you running the latest version?
  • Are you reporting to the correct repository?
    (enso is made of many specialized packages: https://github.com/laravel-enso)
  • Did you check the documentation?
  • Did you perform a cursory search?

Description

After click on edit button e.g. in userGroups table I get the following warning after update to Vue 3:
image

I tried to add emits: ['edit'], to @enso-ui/user-groups/src/bulma/pages/userGroups/Index.vue but it did not remove the warning.

Steps to Reproduce

  1. Log in
  2. Open developer console
  3. Go to Administration -> User Groups
  4. Click on edit on one row

Expected behavior

No warning

Actual behavior

Warning

@aocneanu
Copy link
Member

aocneanu commented Mar 6, 2022

The warning is caused by vue3, which recommends documenting all events in the component that emits them.

Unfortunately, dynamic event names is not supported yet, but don't worry, you won't have any problems with it.

Meanwhile you can follow vuejs/rfcs#204

@mauthi
Copy link
Contributor Author

mauthi commented Mar 18, 2022

Thx - in that case I will close this.

@mauthi mauthi closed this as completed Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants