Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates github star design #58

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

jakebogan01
Copy link
Contributor

I updated the github star icon design. I also tested it on multiple browsers in desktop and mobile.

Screenshot 2024-04-18 133857
Screenshot 2024-04-18 133907

Copy link
Member

@xuelink xuelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you

iPhone SE as well.

Simulator Screenshot - iPhone SE (3rd generation) - 2024-04-18 at 21 53 51

@xuelink xuelink merged commit 55ca77c into langx:main Apr 18, 2024
1 check passed
Copy link
Member

@xuelink xuelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@xuelink
Copy link
Member

xuelink commented Apr 18, 2024

#31

@jakebogan01 jakebogan01 deleted the issue-31-fix-github-star-counter branch April 18, 2024 19:07
@jakebogan01
Copy link
Contributor Author

@xuelink No problem 👍

@xuelink xuelink linked an issue Apr 19, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] : Flowing github star counter in header
2 participants