Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update the .gitignore file to include opensearch,pgvector,and myscale #8470

Merged
merged 1 commit into from
Sep 17, 2024
Merged

chore: update the .gitignore file to include opensearch,pgvector,and myscale #8470

merged 1 commit into from
Sep 17, 2024

Conversation

hwzhuhao
Copy link
Contributor

@hwzhuhao hwzhuhao commented Sep 15, 2024 •
edited
Loading

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

close #8471

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 15, 2024
@laipz8200
Copy link
Collaborator

It looks like you have modified both the .gitignore and docker-compose.yaml files in a single pull request. Could you please split these changes into two separate PRs? Also, it would be great if you could create a new issue to explain the reasons for the changes made to the docker-compose.yaml file.

@hwzhuhao
Copy link
Contributor Author

@laipz8200 The reason for modifying docker-compose.pgvecto-rs.yaml is to maintain consistency with the paths mounted in docker-compose.yaml. This way, it can ensure consistency of directories in the gitignore file. If you still feel that two PRs are necessary, I can adjust it so that the changes in this PR are limited to the gitignore file only first.

@laipz8200
Copy link
Collaborator

Will this change cause compatibility issues for users currently using this directory? In fact, we have already stopped maintaining the files under the legacy directory.

My suggestion is to split the PR into two parts. We can first merge the changes to the .gitignore file. Then, we can continue discussing whether we need to modify the Docker Compose configuration file.

@hwzhuhao
Copy link
Contributor Author

ok, I have update it, pls help me to review it again, thanks. @laipz8200

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 17, 2024
@laipz8200 laipz8200 merged commit e896d1e into langgenius:main Sep 17, 2024
3 checks passed
laipz8200 pushed a commit that referenced this pull request Sep 18, 2024
@hwzhuhao @laipz8200
chore: update the .gitignore file to include opensearch,pgvector,and …
dd9e3ae 
…myscale (#8470)
AAEE86 pushed a commit to AAEE86/dify that referenced this pull request Sep 18, 2024
@hwzhuhao @AAEE86
chore: update the .gitignore file to include opensearch,pgvector,and …
a349689 
…myscale (langgenius#8470)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laipz8200 laipz8200 laipz8200 approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update the .gitignore file to include opensearch,pgvector,and myscale
2 participants
@hwzhuhao @laipz8200