Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing dependency on zend-loader #40

Closed
michalbundyra opened this issue Jan 15, 2020 · 2 comments · Fixed by #95
Closed

Consider removing dependency on zend-loader #40

michalbundyra opened this issue Jan 15, 2020 · 2 comments · Fixed by #95

Comments

@michalbundyra
Copy link
Member

I have seen that this package requires zendframework/zend-loader, just for one class, the Zend\Mail\Header\HeaderLoader.

However, this class basically defines a map to resolve header names to class names.

Would you be open to replace this by a simple array map in the Zend\Mail\Headers class? This would let us drop the requirement on zendframework/zend-loader (assuming I'm not missing anything...).

I could do it if you want.


Originally posted by @acelaya at zendframework/zend-mail#185

@michalbundyra
Copy link
Member Author

LGTM: kill it 👍

On 15 Dec 2017 23:42, "Alejandro Celaya" [email protected] wrote:

I have seen that this package requires zendframework/zend-loader, just
for one class, the Zend\Mail\Header\HeaderLoader.

However, this class basically defines a map to resolve header names to
class names.

Would you be open to replace this by a simple array map in the
Zend\Mail\Headers class? This would let us drop the requirement on
zendframework/zend-loader (assuming I'm not missing anything...).

I could do it if you want.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
zendframework/zend-mail#185, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAJakA0Io3UFHVl5vZQRH2NYFXA4I7aHks5tAvXCgaJpZM4REFdX
.


Originally posted by @Ocramius at zendframework/zend-mail#185 (comment)

@samsonasik
Copy link
Member

I've created PR #95 for it.

samsonasik added a commit to samsonasik/laminas-mail that referenced this issue Jul 23, 2020
@samsonasik samsonasik linked a pull request Jul 23, 2020 that will close this issue
artemii-karkusha pushed a commit to artemii-karkusha/laminas-mail that referenced this issue May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants