Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set _ENV as attributes #24

Open
weierophinney opened this issue Dec 31, 2019 · 1 comment
Open

Set _ENV as attributes #24

weierophinney opened this issue Dec 31, 2019 · 1 comment
Labels
Awaiting Author Updates Enhancement Feature Request

Comments

@weierophinney
Copy link
Member

Perhaps it makes sense to pass to the constructor $attributes like $_ENV.

Originally posted by @easy-system at zendframework/zend-diactoros#156
@weierophinney weierophinney mentioned this issue Dec 31, 2019
Open
@Xerkus Xerkus changed the title ServerRequest Set _ENV as attributes May 1, 2023
@Xerkus
Copy link
Member

Xerkus commented May 2, 2023

Considering that environment might contain secrets, eg when docker container is configured with env variables, I do not think diactoros should be setting $_ENV values as attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Awaiting Author Updates Enhancement Feature Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@weierophinney @Xerkus @boesing