Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI does not allow easily path interpretation #129

Open
niftylettuce opened this issue Aug 27, 2017 · 3 comments
Open

CLI does not allow easily path interpretation #129

niftylettuce opened this issue Aug 27, 2017 · 3 comments

Comments

@niftylettuce
Copy link

After installing the package globally, it is not easy to get the paths of the files (it's undocumented in the Readme). To the average user it is probably non-trivial to how to do get the full path to the yaml files installed in the directory where emojipacks is.

We should probably check file path passed to see if it's in packs folder.

For example:

Path or URL of Emoji yaml file: animals.yaml
Does the path to the yaml file look right? :)

It should allow animals.yaml, and just animals itself.

@niftylettuce
Copy link
Author

I'll be submitting a PR that resolves this.

@niftylettuce
Copy link
Author

Nevermind, the codebase is a mess, there's generators defined that don't even have yields. If anyone else wants to do this go ahead.

@zachfeldman
Copy link
Contributor

@niftylettuce thanks for bringing this up!

I'll leave this issue open for a while to see if anyone is interested in helping out besides yourself.

I've traditionally just given the full URL of an emojipack raw from GitHub which works well for me, but I'm just one user....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants