From db708e3f1c91f427a0a3b5b98382f26389aabb2c Mon Sep 17 00:00:00 2001 From: greged93 <82421016+greged93@users.noreply.github.com> Date: Mon, 4 Dec 2023 21:02:43 +0100 Subject: [PATCH] small fix to cancel duplicate workflow file (#1497) * fix the cancel duplicate job * remove cancel duplicate for bench * remove cancel_duplicates workflow * changelog * update concurrency setting --- .github/workflows/cancel_duplicate.yml | 25 ------------------------- .github/workflows/rust.yml | 4 ++++ CHANGELOG.md | 4 +++- 3 files changed, 7 insertions(+), 26 deletions(-) delete mode 100644 .github/workflows/cancel_duplicate.yml diff --git a/.github/workflows/cancel_duplicate.yml b/.github/workflows/cancel_duplicate.yml deleted file mode 100644 index 5b05d23f0a..0000000000 --- a/.github/workflows/cancel_duplicate.yml +++ /dev/null @@ -1,25 +0,0 @@ -name: cancel-duplicates - -on: - pull_request: - branches-ignore: main - -jobs: - cancel-multiple-workflow-runs: - name: "Cancel the self CI workflow run" - runs-on: ubuntu-latest - steps: - - name: "Cancel rust workflow" - uses: potiuk/cancel-workflow-runs@master - with: - cancelMode: allDuplicates - cancelFutureDuplicates: true - token: ${{ secrets.GITHUB_TOKEN }} - workflowFileName: rust.yml - - name: "Cancel benchmark workflow" - uses: potiuk/cancel-workflow-runs@master - with: - cancelMode: allDuplicates - cancelFutureDuplicates: true - token: ${{ secrets.GITHUB_TOKEN }} - workflowFileName: bench_pull_request.yml diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 32a20befbd..178d7b52ba 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -7,6 +7,10 @@ on: pull_request: branches: [ '**' ] +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + env: CARGO_TERM_COLOR: always CAIRO_PROGRAMS_PATH: | diff --git a/CHANGELOG.md b/CHANGELOG.md index 7f1172934c..0dad49eb86 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,13 +2,15 @@ #### Upcoming Changes +* chore: remove cancel-duplicates workflow [#1497](https://github.com/lambdaclass/cairo-vm/pull/1497) + * feat: Handle `pc`s outside of program segment in `VmException` [#1501] (https://github.com/lambdaclass/cairo-vm/pull/1501) * `VmException` now shows the full pc value instead of just the offset (`VmException.pc` field type changed to `Relocatable`) * `VmException.traceback` now shows the full pc value for each entry instead of hardcoding its index to 0. * Disable debug information for errors produced when `pc` is outside of the program segment (segment_index != 0). `VmException` fields `inst_location` & `error_attr_value` will be `None` in such case. -* feat: Allow running instructions from pcs outside the program segement [#1493](https://github.com/lambdaclass/cairo-vm/pull/14923) +* feat: Allow running instructions from pcs outside the program segement [#1493](https://github.com/lambdaclass/cairo-vm/pull/1493) * BREAKING: Partially Revert `Optimize trace relocation #906` [#1492](https://github.com/lambdaclass/cairo-vm/pull/1492)