From aad4dc9d08990f8e4e0df66017bf59f030d67036 Mon Sep 17 00:00:00 2001 From: Federica Date: Fri, 24 Nov 2023 17:43:26 -0300 Subject: [PATCH 1/3] Make relocate_trace public --- CHANGELOG.md | 2 +- vm/src/vm/runners/cairo_runner.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 287c548aa2..b2123c23b9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,7 +5,7 @@ * feat: Partially Revert `Optimize trace relocation #906` [#1492](https://github.com/lambdaclass/cairo-vm/pull/1492) * Remove methods `VirtualMachine::get_relocated_trace`& `VirtualMachine::relocate_trace` - * Add `relocated_trace` field to `CairoRunner` + * Add `relocated_trace` field & `relocate_trace` method to `CairoRunner` * feat: add debugging capabilities behind `print` feature flag. [#1476](https://github.com/lambdaclass/cairo-vm/pull/1476) diff --git a/vm/src/vm/runners/cairo_runner.rs b/vm/src/vm/runners/cairo_runner.rs index 68bf5f2fa8..1845833ec5 100644 --- a/vm/src/vm/runners/cairo_runner.rs +++ b/vm/src/vm/runners/cairo_runner.rs @@ -762,7 +762,7 @@ impl CairoRunner { } ///Relocates the VM's trace, turning relocatable registers to numbered ones - fn relocate_trace( + pub fn relocate_trace( &mut self, vm: &VirtualMachine, relocation_table: &Vec, From 5c517d8ee6157935418335eee992eca8c37a6dec Mon Sep 17 00:00:00 2001 From: Federica Date: Fri, 24 Nov 2023 17:45:30 -0300 Subject: [PATCH 2/3] List breaking changes --- CHANGELOG.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b2123c23b9..c001a80f73 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,10 +2,11 @@ #### Upcoming Changes -* feat: Partially Revert `Optimize trace relocation #906` [#1492](https://github.com/lambdaclass/cairo-vm/pull/1492) +* BREAKING: Partially Revert `Optimize trace relocation #906` [#1492](https://github.com/lambdaclass/cairo-vm/pull/1492) - * Remove methods `VirtualMachine::get_relocated_trace`& `VirtualMachine::relocate_trace` - * Add `relocated_trace` field & `relocate_trace` method to `CairoRunner` + * Remove methods `VirtualMachine::get_relocated_trace`& `VirtualMachine::relocate_trace`. + * Add `relocated_trace` field & `relocate_trace` method to `CairoRunner`. + * Swap `TraceEntry` for `RelocatedTraceEntry` type in `write_encoded_trace` & `PublicInput::new` signatures. * feat: add debugging capabilities behind `print` feature flag. [#1476](https://github.com/lambdaclass/cairo-vm/pull/1476) From 8ca276fc3e337b7f64a2afa1a33325a2380c7223 Mon Sep 17 00:00:00 2001 From: Federica Date: Fri, 24 Nov 2023 17:47:19 -0300 Subject: [PATCH 3/3] List pr purpose in changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index c001a80f73..b2a21be759 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,7 @@ * Remove methods `VirtualMachine::get_relocated_trace`& `VirtualMachine::relocate_trace`. * Add `relocated_trace` field & `relocate_trace` method to `CairoRunner`. * Swap `TraceEntry` for `RelocatedTraceEntry` type in `write_encoded_trace` & `PublicInput::new` signatures. + * Now takes into account the program counter's segment index when building the execution trace instead of assuming it to be 0. * feat: add debugging capabilities behind `print` feature flag. [#1476](https://github.com/lambdaclass/cairo-vm/pull/1476)