Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to MLJ.jl #8

Open
azev77 opened this issue May 1, 2020 · 10 comments
Open

Port to MLJ.jl #8

azev77 opened this issue May 1, 2020 · 10 comments

Comments

@azev77
Copy link

azev77 commented May 1, 2020

Hi and thank you for this package!
have you considered porting it to MLJ.jl?

@filipebraida
Copy link
Collaborator

Yes, we are.

However, we are currently working on a big project and I don't know if we would be able to change PLS in the short term.

@lalvim

@azev77
Copy link
Author

azev77 commented May 1, 2020

Sounds good.
Btw, porting a package to MLJ usually involves adding one script to the repo.
For example: ParallelKmeans.jl does this in mlj_interface.jl.

@filipebraida
Copy link
Collaborator

Thanks. I'll check with @lalvim to do this. It seems to be easy to porting.

@lalvim
Copy link
Owner

lalvim commented Jun 2, 2020 via email

@azev77
Copy link
Author

azev77 commented Jun 2, 2020

@lalvim soinds great.
I discovered MLJ, by searching google “ML in Julia...”
I discovered your package, searching PLS julia
I try to contribute to MLJ a little when I can.

Check out my script to automatically run all appropriate MLJ models:

https://discourse.julialang.org/t/custom-xgboost-loss-function-w-zygote-julia-computing-blog-post/35811/13?u=albert_zevelev

@azev77
Copy link
Author

azev77 commented Jun 3, 2020

@ablaom @tlienart check out this package. They are working on an MLJ interface.

@lalvim
Copy link
Owner

lalvim commented Jun 3, 2020 via email

@tlienart
Copy link
Collaborator

tlienart commented Jun 3, 2020

Hello! great that you'd like to use MLJ as the default interface and awesome for PLS; I'd be happy if we could run some comparisons with the more classic models in MLJLinearModels.jl at some point.

I have a fair few comments for the MLJ interface (e.g.: you don't need to using MLJ), would you guys mind

  1. adding me as a collaborator
  2. opening a PR from your #mlj branch so that I can comment on it?

thanks!

@filipebraida
Copy link
Collaborator

Thank you for your help!
I created the PR and added you as a reviewer.

@ablaom
Copy link
Contributor

ablaom commented Sep 17, 2021

@filipebraida I think this can be closed, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants