Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kpls.jl trainer contains unused (but populated) matrix #21

Open
donkeykonkey opened this issue Dec 22, 2020 · 0 comments
Open

kpls.jl trainer contains unused (but populated) matrix #21

donkeykonkey opened this issue Dec 22, 2020 · 0 comments

Comments

@donkeykonkey
Copy link

donkeykonkey commented Dec 22, 2020 •
edited
Loading

A N x n_factors matrix, P, is allocated on line 59 in kpls.jl and then populated on line 103 but is otherwise unused. Not sure if julia optimizes it away, but if not it can be a pretty sizeable allocation that should be removed.
@donkeykonkey donkeykonkey changed the title kpls.jl trainer contains unused variable kpls.jl trainer contains unused (but populated) matrix Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@donkeykonkey