Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transposed not translated correctly #7

Open
baggepinnen opened this issue Apr 3, 2019 · 3 comments
Open

Transposed not translated correctly #7

baggepinnen opened this issue Apr 3, 2019 · 3 comments

Comments

@baggepinnen
Copy link

X = u*v'; is translated to X = u*v''
probably confuses it with a string

@lakras
Copy link
Owner

lakras commented Apr 18, 2019

Hi! Thank you so much for this, and sorry about my delay in responding. The translator currently only translates quotes as quotes if they appear in pairs on the same line. If you just enter X = u*v'; on one line on its own, it shouldn't change the ' to a ". It's a tricky problem, determining whether something is a quote or a transposition. If you have any suggestions I would of course welcome them, or if you've noticed it doing this even when the quotation marks are not appearing in pairs on the same line. Sorry I don't have a better fix!

@mattiasvillani
Copy link

Related: CKtheta = chol(Ktheta,'lower')'; is wrongly translated to CKtheta = chol(Ktheta,"lower')"

@mattiasvillani
Copy link

The chol is probably a problem in itself, at least on sparse matrices, where Julia does things differently from Matlab with respect to the ordering. See for example: http://artadia.blogspot.com/2019/10/sparse-cholesky-decomposition-in-julia.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants