Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan always returns strings from category type 'javascript' and 'language' #131

Open
westo27 opened this issue Sep 25, 2019 · 1 comment
Labels
Milestone

Comments

@westo27
Copy link

westo27 commented Sep 25, 2019

Hey, whenever I do a scan it always seems to return strings from these two categories.
I've tried excluding it from the scan by adding 'ignoredCategories' => ['javascript'], to the config file but it doesn't seem to do anything. If I try to exclude a different category in this way it works fine.

The strings seem to be stored in the backend of the extension, so it's odd that it grabs them when I've set the root to the front end and set scanning the root parent directory to false.

But regardless, even if it's scanning these strings it shouldn't return them if I've configured it to ignore this category.

Capture

@moltam moltam added the bug label Sep 25, 2019
@moltam moltam added this to the 1.7.x milestone Sep 25, 2019
@PavelFil
Copy link

As a temporary solution you can remove the JavaScript Scanner from the scanners list.

'modules' =>   [
    'translatemanager' => [
        ...
        'scanners' => [
            '\lajax\translatemanager\services\scanners\ScannerPhpFunction',
            '\lajax\translatemanager\services\scanners\ScannerPhpArray',
            '\lajax\translatemanager\services\scanners\ScannerDatabase',
        ],
    ],
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants