fix(epw): Determine leap year from datetimes when flag is not present

This commit also fixes a number of PEP8 styling issues.

Author: chriswmackey

ladybug/config.py

@@ -192,7 +192,7 @@ def _load_from_file(self, file_path):
                     paths = json.load(cfg)
                 except Exception as e:
                     print('Failed to load paths from {}.\nThey will be set to defaults '
-                        'instead\n{}'.format(file_path, e))
+                          'instead\n{}'.format(file_path, e))
                 else:
                     for key, p in paths.items():
                         if not key.startswith('__') and p.strip():

ladybug/datatype/volumeflowrate.py

@@ -3,7 +3,6 @@
 from __future__ import division
 
 from .base import DataTypeBase
-from .volume import Volume
 from .volumeflowrateintensity import VolumeFlowRateIntensity
 
 

ladybug/epw.py

@@ -514,7 +514,12 @@ def _import_header(self, header_lines):
 
         # parse leap year, daylight savings and comments.
         leap_dl_sav = header_lines[4].strip().split(',')
-        self._is_leap_year = True if leap_dl_sav[1] == 'Yes' else False
+        if leap_dl_sav[1] == 'Yes':
+            self._is_leap_year = True
+        elif leap_dl_sav[1] == 'No':
+            self._is_leap_year = False
+        else:
+            self._is_leap_year = None
         self.daylight_savings_start = leap_dl_sav[2]
         self.daylight_savings_end = leap_dl_sav[3]
         comments_1 = header_lines[5].strip().split(',')
@@ -530,6 +535,8 @@ def _import_body(self, body_lines):
         """Set all of the EPW data collections by parsing from the body lines."""
         # get the number of fields and make an annual analysis period
         self._num_of_fields = min(len(body_lines[0].strip().split(',')), 35)
+        if self.is_leap_year is None:
+            self._is_leap_year = True if len(body_lines) == 8784 else False
         analysis_period = AnalysisPeriod(is_leap_year=self.is_leap_year)
 
         # create headers and an empty list for each field in epw file
@@ -1306,9 +1313,10 @@ def sky_temperature(self):
 climate-calculations.html#energyplus-sky-temperature-calculation
         """
         # create sky temperature header
-        sky_temp_header = Header(data_type=temperature.SkyTemperature(), unit='C',
-                                 analysis_period=AnalysisPeriod(),
-                                 metadata=self._metadata)
+        sky_temp_header = Header(
+            data_type=temperature.SkyTemperature(), unit='C',
+            analysis_period=AnalysisPeriod(is_leap_year=self.is_leap_year),
+            metadata=self._metadata)
 
         # calculate sy temperature for each hour
         horiz_ir = self._get_data_by_field(12).values

ladybug/monthlychart.py

@@ -513,7 +513,7 @@ def _compute_hourly_lines(self):
                         up_vals, low_vals = self._hour_y_values_stack_split(
                             data, d_range, min_val, step, prev_y_up, prev_y_low, d_i)
                         lines_up = self._hour_polylines(up_vals, x_dist)
-                        lines_low =self._hour_polylines(low_vals, x_dist)
+                        lines_low = self._hour_polylines(low_vals, x_dist)
                         lines.extend(lines_up)
                         lines.extend(lines_low)
                         total_len = len(lines_up) + len(lines_low)
@@ -531,7 +531,7 @@ def _compute_hourly_lines(self):
                             else:
                                 prev_y_low = low_vals
                         lines_up = self._hour_polylines(up_vals, x_dist)
-                        lines_low =self._hour_polylines(low_vals, x_dist)
+                        lines_low = self._hour_polylines(low_vals, x_dist)
                         lines.extend(lines_up)
                         lines.extend(lines_low)
                         total_len = len(lines_up) + len(lines_low)
@@ -548,7 +548,7 @@ def _compute_hourly_lines(self):
                     low_vals = self._hour_y_values(data[0], d_range, min_val, step)
                     up_vals = self._hour_y_values(data[-1], d_range, min_val, step)
                     lines_up = self._hour_polylines(up_vals, x_dist)
-                    lines_low =self._hour_polylines(low_vals, x_dist)
+                    lines_low = self._hour_polylines(low_vals, x_dist)
                     lines.extend(lines_up)
                     lines.extend(lines_low)
                     total_len = len(lines_up) + len(lines_low)
@@ -583,7 +583,7 @@ def _compute_monthly_per_hour_lines(self):
                         prev_y = prev_y_up if pos else prev_y_low
                         vals = self._hour_y_values_stack(
                             data, d_range, min_val, step, prev_y)
-                         # set start y so the next data stacks
+                        # set start y so the next data stacks
                         if pos:
                             prev_y_up = vals
                         else:

ladybug/psychchart.py

@@ -103,7 +103,7 @@ class PsychrometricChart(object):
     def __init__(self, temperature, relative_humidity, average_pressure=101325,
                  legend_parameters=None, base_point=Point2D(), x_dim=1, y_dim=1500,
                  min_temperature=-20, max_temperature=50, max_humidity_ratio=0.03,
-                 use_ip=False): 
+                 use_ip=False):
         """Initialize Psychrometric Chart."""
         # check and assign the temperature and humidity
         self._use_ip = bool(use_ip)