Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding and Masking Settings during Training #126

Open
1 task done
Ching-Yee-Chan opened this issue Sep 30, 2024 · 0 comments
Open
1 task done

Padding and Masking Settings during Training #126

Ching-Yee-Chan opened this issue Sep 30, 2024 · 0 comments
Labels
question Further information is requested

Comments

@Ching-Yee-Chan
Copy link

Ching-Yee-Chan commented Sep 30, 2024

Due diligence

  • I have done my due diligence in trying to find the answer myself.

Topic

The paper

Question

My question is about how maximum sequence length is set and how masked loss is computed during batched training of Moshi. Specifically, I suppose that the batched input and target of an SFT training step be in the below format:

32e1132af19f9adde71da0b9784414e

My questions are as follows:

  1. Are losses at position ① summed into the final loss? If so, what are the ground truth labels of these positions? (We guess that there may be three types of padding tokens in the text layer, and the choice of the last token target may affect how Moshi determine the ending point of its response?)
  2. Are losses at position ② summed into the final loss? (i.e, did you apply a padding mask during batched training and how?)
  3. Are losses at position ③ summed into the final loss?
  4. How did you set the maximum length T of a batch sequence? (Say, if running on an 80GB GPU)?

Thanks!

@Ching-Yee-Chan Ching-Yee-Chan added the question Further information is requested label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant