Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger warning for PRs likely requiring updates to management-plane-charts #2089

Closed
2 tasks done
c-pius opened this issue Dec 3, 2024 · 1 comment · Fixed by #2219
Closed
2 tasks done

Trigger warning for PRs likely requiring updates to management-plane-charts #2089

c-pius opened this issue Dec 3, 2024 · 1 comment · Fixed by #2219
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. research

Comments

@c-pius
Copy link
Contributor

c-pius commented Dec 3, 2024

Description

Find a way that notifies us when PRs to lifecycle-manager are likely requiring changes to management-plane-charts. For instance, changes to the configuration or the E2E test files (we used to have a github action that was comparing the make manifests" outcome between main head and PR). If there are changes, it is likely that we also need to modify something in management-plane-charts and the developer should double check.

Document what is expected from the assignee in case the above is triggered. E.g., extend the AC of the original issue to account for the changes in management-plane-charts, create a PR that is preparing and testing the required change and can serve as a base for the release manager to create the new release.

Reasons

Prevent delayed releases due to the release manager finding out too late that changes to the charts are needed.

Acceptance Criteria

Timeboxed to 1 day

  • approach identifying critical changes aligned and implemented
  • documentation available stating what should be done if so

Feature Testing

No response

Testing approach

No response

Attachments

No response

@medmes

This comment has been minimized.

@c-pius c-pius assigned medmes and unassigned c-pius Feb 5, 2025
@lindnerby lindnerby assigned c-pius and unassigned medmes Feb 12, 2025
@c-pius c-pius assigned medmes and unassigned c-pius Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. research
Projects
None yet
2 participants