New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defaultHide is not working when display is modified. #8

Open

ahmohamed opened this issue Aug 30, 2015 · 0 comments

ahmohamed commented Aug 30, 2015

I'm using a customShow as follows

nanoModal.customShow = function(defaultShow, modalAPI) {
    defaultShow();
    modalAPI.modal.el.style.display = 'flex';
    modalAPI.modal.el.style['flex-direction'] ='column';
    modalAPI.modal.el.style['max-height'] = 0.8 * el.node().parentNode.clientHeight;
};

This disables the the defaultHide unless I revert to display = 'block' back again. I can see the probelm stemming from:

var isShowing = function() {
    return el.style && el.style.display === "block";
};

Is there a reason why it can't be el.style.display !== "none"?

Thanks

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment